Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: metrics: refactor histogram bucket generation and testing #109805

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jmcarp
Copy link
Collaborator

@jmcarp jmcarp commented Aug 31, 2023

Backport 1/1 commits from #107388.

/cc @cockroachdb/release


This commit refactors histogram bucketing for legibility and composibility. It also introduces a data-driven test for histogram bucket generation.

This refactor should make it easier to add additional metric categories, distributions, and bucket types.

Part of #97144.

Release note: None


Release justification: low-risk, test-only change. Unblocks backport of #104302.

This commit refactors histogram bucketing for legibility
and composibility. It also introduces a data-driven test
for histogram bucket generation.

This refactor should make it easier to add additional
metric categories, distributions, and bucket types.

Part of cockroachdb#97144.

Release note: None
@jmcarp jmcarp requested a review from ericharmeling August 31, 2023 14:09
@jmcarp jmcarp requested a review from a team as a code owner August 31, 2023 14:09
@jmcarp jmcarp requested a review from a team August 31, 2023 14:09
@jmcarp jmcarp requested review from a team as code owners August 31, 2023 14:09
@jmcarp jmcarp requested a review from a team August 31, 2023 14:09
@jmcarp jmcarp requested review from a team as code owners August 31, 2023 14:09
@blathers-crl
Copy link

blathers-crl bot commented Aug 31, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@jmcarp jmcarp requested review from adityamaru and removed request for a team August 31, 2023 14:09
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 31, 2023
@jmcarp jmcarp requested review from miretskiy and michae2 and removed request for a team August 31, 2023 14:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jmcarp
Copy link
Collaborator Author

jmcarp commented Aug 31, 2023

For context, I would like to backport this patch so that I can then backport native histogram support, which we're expecting to help with resource use for the monitoring stack. I checked with @ericharmeling, and I believe both this patch and the next one I want to backport are low-risk. This patch is a refactor that shouldn't have any effect on behavior, and the native histograms patch adds support for a new histogram format that will be gated by an environment flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants