allocator: change some log.VEventf to log.VInfof #109804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When investigating delays in the allocator simulator test, we found that a significant amount of time were spent on log.VEvent. Upon investigating, the log events removed in this patch are those that occurred most frequently during testing. I'm considering removing some of the log events here and would appreciate a second pair of eye to better decide whether these log events are useful for tracing. See also: cockroachdb#107420 Part of: cockroachdb#107421 Release note: none
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
wenyihu6
commented
Aug 31, 2023
| @@ -263,7 +263,7 @@ func (rp ReplicaPlanner) PlanOneChange( | |||
| // NB: the replication layer ensures that the below operations don't cause | |||
| // unavailability; see kvserver.execChangeReplicasTxn. | |||
| action, allocatorPrio := rp.allocator.ComputeAction(ctx, rp.storePool, conf, desc) | |||
| log.KvDistribution.VEventf(ctx, 1, "next replica action: %s", action) | |||
| log.KvDistribution.VInfof(ctx, 1, "next replica action: %s", action) | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating delays in the allocator simulator test, we found that a
significant amount of time were spent on log.VEvent. Upon investigating, the log
events removed in this patch are those that occurred most frequently during
testing. I'm considering removing some of the log events here and would
appreciate a second pair of eye to better decide whether these log events are
useful for tracing.
See also: #107420
Part of: #107421
Release note: none