server,sql: add status server endpoint to request profiler details #109782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
force-pushed
the
move-to-resumer-model
branch
from
7176157 to
21702a5
Compare
adityamaru
commented
Sep 1, 2023
| Knobs: base.TestingKnobs{ | ||
| JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), | ||
| Server: &TestingKnobs{ | ||
| DialNodeCallback: func(ctx context.Context, nodeID roachpb.NodeID) error { |
There was a problem hiding this comment.
if there is an easier way to check that a particular node was dialed and returned us the response i'm all ears, i looked around but couldn't find any
adityamaru
force-pushed
the
move-to-resumer-model
branch
from
21702a5 to
7e6c795
Compare
This change introduces a new status server endpoint to request job profiler details. This endpoint will redirect the request to the current coordinator node of the job in question. This will be useful because in a followup we will load the resumer from the coordinator node's job registry and trigger its specific job profiler detail collection logic. This is the first step of a few to move to a "fetch model" rather than have each resumer dump their execution details at some arbitrary cadence. The core logic involved in collecting profiler details has not changed, it has been moved in its entirety from pkg/sql to pkg/server. The `crdb_internal.request_job_execution_details` builtin now resolves the job's coordinator ID and calls the new status server endpoint. Informs: cockroachdb#109671 Release note: None
adityamaru
force-pushed
the
move-to-resumer-model
branch
from
7e6c795 to
a99de9f
Compare
dt
approved these changes
Sep 5, 2023
|
flake looks like #109240 |
|
TFTR! bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new status server endpoint to
request job profiler details. This endpoint will redirect
the request to the current coordinator node of the job in
question. This will be useful because in a followup we will
load the resumer from the coordinator node's job registry
and trigger its specific job profiler detail collection logic.
This is the first step of a few to move to a "fetch model" rather
than have each resumer dump their execution details at some
arbitrary cadence.
The core logic involved in collecting profiler details has not changed,
it has been moved in its entirety from pkg/sql to pkg/server. The
crdb_internal.request_job_execution_detailsbuiltin now resolvesthe job's coordinator ID and calls the new status server endpoint.
Informs: #109671
Release note: None