Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: difference built-in as wrong return value type #109752

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 30, 2023

Backport 1/1 commits from #109731 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, when the difference built-in was added into CRDB, the return type was text instead of integer. To address this, this patch fixes the return type to match Postgres.

Fixes: #109666

Release note (bug fix): The difference builtin had its return type incorrectly set to a string instead of an integer.


Release justification: low risk bug fix

Previously, when the difference built-in was added into
CRDB, the return type was text instead of integer. To
address this, this patch fixes the return type to
match Postgres.

Fixes: #109666

Release note (bug fix): The difference builtin had its
return type incorrectly set to a string instead of an integer.
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 30, 2023 19:40
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-109731 branch from dbaeba7 to a7a0451 Compare August 30, 2023 19:40
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 30, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-109731 branch from 24699ac to 026593a Compare August 30, 2023 19:40
@blathers-crl blathers-crl bot requested a review from annrpom August 30, 2023 19:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 30, 2023
@fqazi fqazi merged commit 953350f into release-23.1 Aug 31, 2023
@fqazi fqazi deleted the blathers/backport-release-23.1-109731 branch August 31, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants