Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: parser: validate privilege name when parsing #109706

Merged
merged 1 commit into from
Aug 30, 2023
Merged

release-23.1: parser: validate privilege name when parsing #109706

merged 1 commit into from
Aug 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 29, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #109595 on behalf of @rafiss.

/cc @cockroachdb/release

Now we differentiate between parsing a privileges name from user input versus from a system table. This allows us to validate names, but still backport names to older branches without causing errors.

No release note, since the user-facing change here is just a better error message.

fixes #109549
fixes #109559
Release note: None

Release justification: low risk bug fix

@rafiss
parser: validate privilege name when parsing
5ecea79 
Now we differentiate between parsing a privileges name from user input
versus from a system table. This allows us to validate names, but still
backport names to older branches without causing errors.

No release note, since the user-facing change here is just a better
error message.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners August 29, 2023 22:50
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-109595 branch 2 times, most recently from d8cbbab to 5ecea79 Compare August 29, 2023 22:50
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 29, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 29, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 29, 2023
@blathers-crl blathers-crl bot requested review from andyyang890 and rafiss August 29, 2023 22:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit f82cfd0 into release-23.1 Aug 30, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-109595 branch August 30, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyyang890 andyyang890 andyyang890 approved these changes

@rafiss rafiss Awaiting requested review from rafiss

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @andyyang890 @rafiss