sql: fix index visibility parsing for small values #109697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgartner
requested review from
herkolategan,
smg260 and
msirek
and removed request for
a team
|
This change is |
mgartner
force-pushed
the
108083-fix-index-invisibility-parsing
branch
from
b4bf1f4 to
4a89d98
Compare
rafiss
reviewed
Aug 29, 2023
| @@ -1059,7 +1060,7 @@ func (og *operationGenerator) createIndex(ctx context.Context, tx pgx.Tx) (*opSt | |||
| Unique: og.randIntn(4) == 0, // 25% UNIQUE | |||
| Inverted: og.randIntn(10) == 0, // 10% INVERTED | |||
| IfNotExists: og.randIntn(2) == 0, // 50% IF NOT EXISTS | |||
| Invisibility: 1 - visibility, // 5% NOT VISIBLE | |||
| Invisibility: visibility, // 5% NOT VISIBLE | |||
There was a problem hiding this comment.
nit: i think this should still be 1 - visibility
There was a problem hiding this comment.
Good catch. Fixed this above.
mgartner
force-pushed
the
108083-fix-index-invisibility-parsing
branch
2 times, most recently
from
70ee664 to
5bb41ae
Compare
This commit updates the parser and AST to keep track of whether or not an index `VISIBILITY` float was provided in a `CREATE TABLE`, `CREATE INDEX`, or `ALTER INDEX` statement. This allows the statements to be round-tripped correctly with very low float values that would be rounded to zero and change the `VISIBILITY` clause into `NOT VISIBLE`. Fixes cockroachdb#108083 Release note: None
mgartner
force-pushed
the
108083-fix-index-invisibility-parsing
branch
from
5bb41ae to
67f9e00
Compare
rafiss
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
nice fix!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @smg260)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the parser and AST to keep track of whether or not
an index
VISIBILITYfloat was provided in aCREATE TABLE,CREATE INDEX, orALTER INDEXstatement. This allows the statementsto be round-tripped correctly with very low float values that would be
rounded to zero and change the
VISIBILITYclause intoNOT VISIBLE.Fixes #108083
Release note: None