Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: handle format of START/BEGIN inside of functions #109618

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 28, 2023

If a transaction is started in a BEGIN ATOMIC block of a function or procedure, it must be formatted with START rather than BEGIN. Otherwise the function body cannot be parsed.

fixes #109561
Release note: None

If a transaction is started in a BEGIN ATOMIC block of a function or
procedure, it must be formatted with START rather than BEGIN. Otherwise
the function body cannot be parsed.

Release note: None
@rafiss rafiss requested review from mgartner, Xiang-Gu and a team August 28, 2023 18:49
@rafiss rafiss requested a review from a team as a code owner August 28, 2023 18:49
@rafiss rafiss added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 28, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this one!

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 29, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 29, 2023

Build succeeded:

@craig craig bot merged commit fa4f9ba into cockroachdb:master Aug 29, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 29, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7ae12d1 to blathers/backport-release-23.1-109618: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/tests: TestRandomSyntaxGeneration failed
3 participants