Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: ensure rangefeed setting is enabled in tests #109506

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

jayshrivastava
Copy link
Contributor

Previously, many tests which create rangefeeds would not explicitly set the kv.rangefeed.enabled setting to be true. These tests would still work because, by default, rangefeeds are enabled via span configs. However, it was observed that span configs are not immediately applied when range splits occur. This would cause the testing rangefeed reader to encounter errors and/or timeout on very rare occasions. See #109306 (comment) for more info.

This change updates these tests to set the kv.rangefeed.enabled cluster setting to be true, which removes the dependency on span configs.

Closes: #109306
Epic: None
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, many tests which create rangefeeds would not
explicitly set the `kv.rangefeed.enabled` setting to be true.
These tests would still work because, by default, rangefeeds
are enabled via span configs. However, it was observed that
span configs are not immediately applied when range splits
occur. This would cause the testing rangefeed reader to
encounter errors and/or timeout on very rare occasions.
See cockroachdb#109306 (comment) for more info.

This change updates these tests to set the `kv.rangefeed.enabled`
cluster setting to be true, which removes the dependency on span
configs.

Closes: cockroachdb#109306
Epic: None
Release note: None
@jayshrivastava jayshrivastava marked this pull request as ready for review August 25, 2023 16:43
@jayshrivastava jayshrivastava requested review from a team as code owners August 25, 2023 16:43
@miretskiy miretskiy added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.1.9-rc labels Aug 25, 2023
@jayshrivastava
Copy link
Contributor Author

bors r=miretskiy

@craig
Copy link
Contributor

craig bot commented Aug 25, 2023

Build succeeded:

@craig craig bot merged commit ee7cdcf into cockroachdb:master Aug 25, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 25, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 0ec2775 to blathers/backport-release-23.1-109506: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 0ec2775 to blathers/backport-release-23.1.9-rc-109506: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.9-rc failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@miretskiy
Copy link
Contributor

@jayshrivastava - you need to try manual backport.

@jayshrivastava jayshrivastava deleted the deflake-evaluator branch August 29, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl/cdceval: TestEvaluator failed
3 participants