build/roachtest: do not exit with code 11 on cluster creation failure #109463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roachtest will exit with code 11 if creating any clusters during a test run failed. However, that is not ideal for a few reasons: * Cluster creation often fails, partly because of temporary unavailability of a resource type in a data center; and partly because of issues in roachtest itself (see cockroachdb#104029). * Exiting with code 11 causes the build to be marked and reported as a failrue on TeamCity/Slack and that's disruptive. We already get cluster creation failure notifications on GitHub. By reporting them as build failures on TeamCity, we mask actually serious issues like the test runner crashing in the middle of the build and not running every test (for a recent example, see cockroachdb#109279). For these reasons, this commit updates the script used by TeamCity to invoke roachtest to also ignore exit code 11 (just like it currently does for exit code 10). This makes roachtest build failures stand out more, as they will mean roachtest was unable to run all tests. Epic: none Release note: None
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
renatolabs
added
the
backport-23.1.x
srosenberg
approved these changes
Aug 24, 2023
herkolategan
approved these changes
Aug 25, 2023
|
TFTRs! bors r=srosenberg,herkolategan |
|
Build succeeded: |
renatolabs
deleted the
rc/roachtest-no-exit-11-on-cluster-creation-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roachtest will exit with code 11 if creating any clusters during a test run failed. However, that is not ideal for a few reasons:
For these reasons, this commit updates the script used by TeamCity to invoke roachtest to also ignore exit code 11 (just like it currently does for exit code 10). This makes roachtest build failures stand out more, as they will mean roachtest was unable to run all tests.
Epic: none
Release note: None