build: explicitly set SKIP_LABEL_TEST_FAILURE in compose.sh #109356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `SKIP_LABEL_TEST_FAILURE` was being set via a teamcity configuration. This change was quite opaque as the majority of CI configuration for Cockroach is stored as shell scripts within its repo. This commit follows that pattern by explicitly setting `SKIP_LABEL_TEST_FAILURE` in the script that runs `TestComposeCompare`. Epic: None Release note: None
chrisseto
added
backport-22.2.x
backport-23.1.x
|
This change is |
rickystewart
approved these changes
Aug 23, 2023
|
TFTR! bors r =rickystewart |
rafiss
reviewed
Aug 23, 2023
| # failures per se. They're cases of behavioral divergences from Postgres. While | ||
| # our compatibility guarantees are not 100%, it's better to treat failures as | ||
| # information to occasionally review. | ||
| export SKIP_LABEL_TEST_FAILURE=1 |
There was a problem hiding this comment.
is this the way to do it, as opposed to how the env vars are passed on line 34? i guess the difference is if the variable is used by the test runner versus the test itself?
There was a problem hiding this comment.
Yes, this is correct. We want the variable to be visible by bazci. Compare to line 34 which sets environment variables for the test inside the sandbox.
|
Whoops, extra space might have tripped bors up. bors r=rickystewart |
|
Build succeeded: |
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
SKIP_LABEL_TEST_FAILUREwas being set via a teamcity configuration. This change was quite opaque as the majority of CI configuration for Cockroach is stored as shell scripts within its repo. This commit follows that pattern by explicitly settingSKIP_LABEL_TEST_FAILUREin the script that runsTestComposeCompare.Epic: None
Release note: None