changefeedccl: refactor kvfeed startup in changeaggregator processor #109345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jayshrivastava
commented
Aug 23, 2023
jayshrivastava
force-pushed
the
kvfeed-refator
branch
3 times, most recently
from
dedeec0 to
f0fc374
Compare
This change cleans up the code used to start up the kv feed in change aggregator processors. This change removes uncessessary code, adds a better API, and makes code easier to reason about. Informs: cockroachdb#96953 Release note: None Epic: None
jayshrivastava
force-pushed
the
kvfeed-refator
branch
from
f0fc374 to
98c762d
Compare
jayshrivastava
changed the title
jayshrivastava
commented
Aug 25, 2023
| ca.eventProducer, err = ca.startKVFeed(ctx, spans, kvFeedHighWater, needsInitialScan, feed) | ||
| // TODO(yevgeniy): Introduce separate changefeed monitor that's a parent | ||
| // for all changefeeds to control memory allocated to all changefeeds. | ||
| pool := ca.flowCtx.Cfg.BackfillerMonitor |
There was a problem hiding this comment.
I will probably add our own monitor in a subsequent PR.
miretskiy
approved these changes
Aug 25, 2023
| // but only the first one is ever used. | ||
| ca.errCh = make(chan error, 2) | ||
| ca.kvFeedDoneCh = make(chan struct{}) | ||
| errCh := make(chan error, 1) |
There was a problem hiding this comment.
are we sure this is safe?
|
bors r=miretskiy |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changefeedccl: refactor kvfeed startup in changeaggregator processor
This change cleans up the code used to start up the kv feed
in change aggregator processors. This change removes uncessessary code,
adds a better API, and makes code easier to reason about.
Informs: #96953
Release note: None
Epic: None