changefeedccl: move node drain handling logic out of kvfeed #109340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jayshrivastava
force-pushed
the
move-drain-logic
branch
from
613acc0 to
a23ceea
Compare
jayshrivastava
requested review from
HonoreDB and
miretskiy
and removed request for
a team
miretskiy
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB and @jayshrivastava)
pkg/ccl/changefeedccl/changefeed_processors.go line 639 at r1 (raw file):
} if err := ca.checkForNodeDrain(); err != nil {
perhaps this should be called in the main loop (Next()?)
pkg/ccl/changefeedccl/kvfeed/kv_feed.go line 241 at r1 (raw file):
defer func() { log.Errorf(ctx, "kvfeed OVERALL run %v\n", err) }()
stray debugging?
jayshrivastava
force-pushed
the
move-drain-logic
branch
from
a23ceea to
36c8cc6
Compare
|
bors r=miretskiy |
|
bors r- |
|
Canceled. |
miretskiy
suggested changes
Aug 23, 2023
Previously, the kvfeed was responsible for monitoring for node drains using a goroutine. This change moves this logic into the change aggregator and removes the goroutine. Overall, this change makes the code more organized and performant. This change was inspired by work being done for cockroachdb#109167. The work in that PR requires being able to restart the kvfeed. Having drain logic intermingled with the kvfeed makes restarts much more complex, hard to review, prone to bugs, etc. Informs: cockroachdb#96953 Release note: None Epic: None
jayshrivastava
force-pushed
the
move-drain-logic
branch
from
36c8cc6 to
d6e7b27
Compare
miretskiy
approved these changes
Aug 23, 2023
|
bors r=miretskiy |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the kvfeed was responsible for monitoring for
node drains using a goroutine. This change moves this logic
into the change aggregator and removes the goroutine.
Overall, this change makes the code more organized and performant.
This change was inspired by work being done for #109167. The
work in that PR requires being able to restart the kvfeed.
Having drain logic intermingled with the kvfeed makes
restarts much more complex, hard to review, prone to bugs, etc.
Informs: #96953
Release note: None
Epic: None