build: update bazel builder build docs #109324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the documentation described a manual build of the `bazelbuilder` docker image. The current approach is to use CI to build the image. This PR updates the documentation to reflect the current process, including the FIPS image steps. Epic: none Release note: None
rail
added
C-enhancement
|
This change is |
rickystewart
approved these changes
Aug 23, 2023
| ``` | ||
| - Then, update `build/.bazelbuilderversion` with the new tag and commit all your changes. | ||
| - Build the image by triggering the `Build and Push Bazel Builder Image` build in TeamCity. The generated image will be published to https://hub.docker.com/r/cockroachdb/bazel. | ||
| - Update `build/.bazelbuilderversion` with the new tag and commit all your changes. |
There was a problem hiding this comment.
With the remote exec change there is actually an extra step: build/toolchains/BUILD.bazel needs to be updated. Specifically we have to put the hashes for the amd64 builder image and the hashes for the arm64 builder image that need to go into the relevant platform() stanza.
You can update this now, or merge as-is and I can update the documentation further.
Also see #108722
|
I'll merge it as is for now :) |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the documentation described a manual build of the
bazelbuilderdocker image. The current approach is to use CI to build the image.This PR updates the documentation to reflect the current process, including the FIPS image steps.
Epic: none
Release note: None