Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: provision 250 MB/s for restore tests on AWS #109278

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Aug 22, 2023

Backport 1/1 commits from #109221.

/cc @cockroachdb/release


The restore/tpce/* family of tests on AWS max out the default 125 MB/s EBS throughput. In contrast, similar tests in GCE provision for more throughput and don't max it out.

This commit bumps the provisioned throughput from 125 MB/s to 250 MB/s in all restore tests on AWS, so that the tests don't work at the edge of overload.

This both brings some parity between testing on GCE and AWS, and reduces likelihood of raft OOMs (which manifest more often when disk is overloaded).

Fixes #106248
Epic: none
Release note: none
Release justification: makes tests less flaky

The restore/tpce/* family of tests on AWS max out the default 125 MB/s EBS
throughput. In contrast, similar tests in GCE provision for more throughput and
don't max it out.

This commit bumps the provisioned throughput from 125 MB/s to 250 MB/s in all
restore tests on AWS, so that the tests don't work at the edge of overload.

This both brings some parity between testing on GCE and AWS, and reduces
likelyhood of raft OOMs (which manifest more often when disk is overloaded).

Fixes cockroachdb#106248
Epic: none
Release note: none
@pav-kv pav-kv requested a review from msbutler August 22, 2023 19:57
@pav-kv pav-kv requested a review from a team as a code owner August 22, 2023 19:57
@pav-kv pav-kv requested review from rachitgsrivastava and smg260 and removed request for a team August 22, 2023 19:57
@blathers-crl
Copy link

blathers-crl bot commented Aug 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv
Copy link
Collaborator Author

pav-kv commented Aug 23, 2023

@msbutler PTAL

@pav-kv pav-kv merged commit 6472dd3 into cockroachdb:release-23.1 Aug 23, 2023
@pav-kv pav-kv deleted the backport23.1-109221 branch August 23, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants