Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update some configurations for remote build execution #109152

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Aug 21, 2023

  1. Use the large pool of executors for enormous test targets
  2. Add (temporary) network access to the following tests: amazon_test,
    base_test, cloudprivilege_test, externalconn_test, and
    cockroach-go-testserver-upgrade-to-master logictests. These
    erroneously have a dependency on network assets; bugs have been
    filed for each of these.

Epic: CRDB-8308
Release note: None

@rickystewart rickystewart requested a review from rail August 21, 2023 16:49
@rickystewart rickystewart requested review from a team as code owners August 21, 2023 16:49
@rickystewart rickystewart requested review from lidorcarmel and michae2 and removed request for a team August 21, 2023 16:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

1. Use the `large` pool of executors for `enormous` test targets
2. Add (temporary) network access to the following tests: `amazon_test`,
   `base_test`, `cloudprivilege_test`, `externalconn_test`, and
   `cockroach-go-testserver-upgrade-to-master` logictests. These
   erroneously have a dependency on network assets; bugs have been
   filed for each of these.

Epic: CRDB-8308
Release note: None
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 50 of 50 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @lidorcarmel and @michae2)

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Aug 21, 2023

Build failed (retrying...):

@craig craig bot merged commit 604a90a into cockroachdb:master Aug 21, 2023
@craig
Copy link
Contributor

craig bot commented Aug 21, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants