roachtest: Cast snapshot-recd bytes to int in disagg-rebalance #109142
Conversation
itsbilal
requested review from
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @renatolabs, and @srosenberg)
pkg/cmd/roachtest/tests/disagg_rebalance.go line 117 at r1 (raw file):
var bytesSnapshotted int64 if err := db.QueryRow( "SELECT metrics['range.snapshots.rcvd-bytes']::DECIMAL FROM crdb_internal.kv_store_status WHERE node_id = $1 LIMIT 1",
should we cast to an INT if we're going to scan into an integer int64 type?
Previously we were reading a float value as an int, which would trip up the Scan() method if the float value was large enough to be wired over in scientified notation eg. `2.3456E7`. This change ensures that Cockroach prints out the value as an int to avoid the scan-time error in the roachtest. Fixes cockroachdb#109114. Epic: none Release note: None
itsbilal
force-pushed
the
disagg-rebalance-dec-cast
branch
from
3eebffb to
06f6a0f
Compare
itsbilal
changed the title
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/disagg_rebalance.go line 117 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
should we cast to an
INTif we're going to scan into an integerint64type?
Good point, done. Shouldn't matter in practice but doesn't hurt to be safe.
|
TFTR! bors r=jbowens |
|
Build succeeded: |
Previously we were reading a float value as an int, which would trip up the Scan() method if the float value was large enough to be wired over in scientified notation eg.
2.3456E7. This change ensures that Cockroach prints out the value as an integer to avoid the scan-time error in the roachtest.Fixes #109114.
Epic: none
Release note: None