ui: use cluster setting from redux on schema insights

[maryliag]

Part Of #108373

Use the value of the cluster setting
sql.index_recommendation.drop_unused_duration from redux, instead of adding as part of the select.
With this change, now users with VIEWACTIVITY or
VIEWACTIVITYREDACTED can see index recommendations on the console, without the need the view cluster settings permission.

This commit changes the Schema Insights Api.

https://www.loom.com/share/6b9ef154c9c44157a45e1e66b1fbc890

Release note (ui change): Users without VIEWCLUSTERSETTINGS permission but with VIEWACTIVITY or VIEWACTIVITYREDACTED can now see index recommendations.

[cockroach-teamcity]

This change is 

[j82w]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @koorosh and @maryliag)

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 396 at r1 (raw file):

const getDatabaseIndexUsageStats: DatabaseDetailsQuery<IndexUsageStatistic> = {
  createStmt: (dbName: string, csIndexUnusedDuration: string) => {
    csIndexUnusedDuration = csIndexUnusedDuration ?? "168h";

Can the 168h be a shard constant somewhere to avoid future bugs if the value is changed?

[j82w]

pkg/ui/workspaces/cluster-ui/src/api/schemaInsightsApi.ts line 150 at r1 (raw file):

  name: "DropIndex",
  query: (csIndexUnusedDuration: string) => {
    csIndexUnusedDuration = csIndexUnusedDuration ?? "168h";

Should there be a console log or something to hint that it's using the hard coded default instead of the clsuter setting?

[maryliag]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @j82w and @koorosh)

---

pkg/ui/workspaces/cluster-ui/src/api/databaseDetailsApi.ts line 396 at r1 (raw file):

Previously, j82w (Jake) wrote…

Can the 168h be a shard constant somewhere to avoid future bugs if the value is changed?

Good idea! Done

---

pkg/ui/workspaces/cluster-ui/src/api/schemaInsightsApi.ts line 150 at r1 (raw file):

Previously, j82w (Jake) wrote…

Should there be a console log or something to hint that it's using the hard coded default instead of the clsuter setting?

On the UI we are already showing the value that was used, so I don't think there are more details that need to be added.

[j82w]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @koorosh)

[maryliag]

bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from f628393 to blathers/backport-release-23.1-109047: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}