Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.9-rc: kv: don't log trace of cancelled requests if not Export #109041

Merged

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 18, 2023

Backport 1/1 commits from #109030 on behalf of @nvanbenschoten.

/cc @cockroachdb/release


This commit limits the logging added in #106611 to only apply to Export requests. The logging has been observed to be noisy and we'd like to avoid any perceived regression in a v23.1 patch release.

Epic: None
Release note: None


Release justification: avoids regression in logging.

This commit limits the logging added in #106611 to only apply to Export
requests. The logging has been observed to be noisy and we'd like to
avoid any perceived regression in a v23.1 patch release.

Epic: None
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 18, 2023 20:38
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.9-rc-109030 branch from 2ce2de1 to ba59765 Compare August 18, 2023 20:38
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 18, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.9-rc-109030 branch from 23354c4 to 9a42623 Compare August 18, 2023 20:38
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 18, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot requested a review from dt August 18, 2023 20:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit a0eff47 into release-23.1.9-rc Aug 19, 2023
@nvanbenschoten nvanbenschoten deleted the blathers/backport-release-23.1.9-rc-109030 branch August 19, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants