Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingest: speed-up c2c cutover #108925

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

lidorcarmel
Copy link
Contributor

Each c2c processor checks the job info table every 30 seconds to see whether a cutover has started. Normally a cutover should take about 10 seconds. This pr changes the default to 10 seconds, to reduce the total time for cutting over.

Epic: none

Release note: None

Each c2c processor checks the job info table every 30 seconds to see
whether a cutover has started. Normally a cutover should take about
10 seconds. This pr changes the default to 10 seconds, to reduce
the total time for cutting over.

Epic: none

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Aug 17, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@lidorcarmel lidorcarmel marked this pull request as ready for review August 17, 2023 19:35
@lidorcarmel lidorcarmel requested a review from a team as a code owner August 17, 2023 19:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are OK with this because this is now directly accessing the job_info table. So we suspect we can poll more often.

@lidorcarmel
Copy link
Contributor Author

+1
TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Aug 17, 2023

Build succeeded:

@craig craig bot merged commit 02065f5 into cockroachdb:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants