-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: use seeded random for schemachange opsgen #108922
Conversation
The failure originated from branch 23.1, but was last seen on 23.1.9-rc - we should backport to the branch that has seen the most recent failure. Not sure if we want to backport to 23.1 as well |
f0d9cfc
to
8133488
Compare
This is great, I remember wanting this in the past (for reproducing test failures). If we're changing this code, it might be a good time to also support passing the seed as a command line argument. Lots of workloads already do it so it would be more consistent. There's some shared code in [1] cockroach/pkg/workload/random.go Lines 26 to 28 in 9849680
[2] cockroach/pkg/workload/bank/bank.go Line 45 in 9849680
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just need to fix the release note!
also, in the PR description can you link to the test that prompted this. add a line like:
informs https://github.com/cockroachdb/cockroach/issues/108695
informs https://github.com/cockroachdb/cockroach/issues/105517
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @annrpom, @herkolategan, and @smg260)
-- commits
line 11 at r1:
nit: this should have Release note: None
since this is not a change that end-users need to know about.
(Forgot to mention my comment is totally optional; that can be done in the future) |
thank you for the suggestion, @renatolabs i'll keep that in mind :] |
A schemachange TestWorkload failure was difficult to reproduce; to address this, this patch uses randutil's `NewTestRand()` to allow for a global seed to be set when stressing this test. Epic: none Release note: none
8133488
to
b21b3e5
Compare
TFTR! ('-')7 bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b21b3e5 to blathers/backport-release-23.1-108922: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. error creating merge commit from b21b3e5 to blathers/backport-release-23.1.9-rc-108922: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.9-rc failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
A schemachange TestWorkload failure was difficult to reproduce; to address this, this patch uses randutil's
NewTestRand()
to allow for a global seed to be set when stressing this test.Epic: none
Informs: #108695
Informs: #105517
Informs: #109218
Release note: none