sqlproxyccl: do not report BackendDown metrics on throttle and routing errors #108914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andy-kimball
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @darinpp and @jeffswenson)
…g errors Previously, we were reporting the backend_down metric on the following errors: - codeProxyRefusedConnection - codeParamsRoutingFailed - codeUnavailable These errors do not imply that the backend is down. We originally introduced this in cockroachdb#57431, and looking at the PR, it appears unintentional. This commit fixes that by not reporting the backend_down metric when the proxy returns such errors. Release note: None Epic: none Release justification: This fixes accuracy issues with SQL Proxy metrics.
jaylim-crl
force-pushed
the
jay/230817-fix-sqlproxy-metrics
branch
from
8425683 to
72e174c
Compare
This commit renames codeBackendDown to codeBackendDialFailed to prevent confusions by developers. Note that we don't rename the metric here to avoid breaking downstream consumers. At the same time, we will remove the old codeBackendRefusedTLS code as it does not serve any purpose, and there wasn't a metric for it as well. Release note: None Epic: none
jaylim-crl
force-pushed
the
jay/230817-fix-sqlproxy-metrics
branch
from
72e174c to
95eb34d
Compare
jaylim-crl
added
the
backport-23.1.x
|
TFTR! bors r=JeffSwenson,andy-kimball |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 95eb34d to blathers/backport-release-23.1-108914: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlproxyccl: do not report BackendDown metrics on throttle and routing errors
Previously, we were reporting the backend_down metric on the following errors:
These errors do not imply that the backend is down. We originally introduced
this in #57431, but looking at the PR, it appears unintentional. This commit
fixes that by not reporting the backend_down metric when the proxy returns
such errors.
Release note: None
Epic: none
sqlproxyccl: rename codeBackendDown to codeBackendDialFailed
This commit renames codeBackendDown to codeBackendDialFailed to prevent
confusions by developers. Note that we don't rename the metric here to avoid
breaking downstream consumers. At the same time, we will remove the old
codeBackendRefusedTLS code as it does not serve any purpose, and there wasn't
a metric for it as well.
Release note: None
Epic: none
Release justification: This fixes accuracy issues with SQL Proxy metrics.