Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstreamer, row: adjust all tests to work with the test tenant #108886

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

yuzefovich
Copy link
Member

Epic: CRDB-18499
Informs #76378

Release note: None

This mostly involved enabling SPLIT AT as well as adjusting the
hard-coded key construction to use the correct codec. SPLIT AT is
enabled via the cluster setting override which required moving all such
tests into `kvstreamer_test`.

Release note: None
This only required using the correct codec. Also add some log scopes.

Release note: None
@yuzefovich yuzefovich requested a review from knz August 17, 2023 03:39
@yuzefovich yuzefovich requested a review from a team as a code owner August 17, 2023 03:39
@yuzefovich yuzefovich requested review from rharding6373 and removed request for a team August 17, 2023 03:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 17, 2023

Build succeeded:

@craig craig bot merged commit 02065f5 into cockroachdb:master Aug 17, 2023
@yuzefovich yuzefovich deleted the mt-sql branch August 17, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants