Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physicalplan: make a couple of tests work with test tenant #108825

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

yuzefovich
Copy link
Member

Two out of three tests tracked by #108763 required only a minor adjustment. However, one of the tests exposed (perhaps previously unknown) difference between single-tenant and multi-tenant configs in terms of populating the range cache. The issue has been repurposed to tracking investigating and addressing that difference.

Addresses: #108763

Epic: None

Release note: None

Two out of three tests tracked by cockroachdb#108763 required only a minor
adjustment. However, one of the tests exposed (perhaps previously
unknown) difference between single-tenant and multi-tenant configs in
terms of populating the range cache. The issue has been repurposed to
tracking investigating and addressing that difference.

Release note: None
@yuzefovich yuzefovich requested a review from knz August 16, 2023 04:08
@yuzefovich yuzefovich requested a review from a team as a code owner August 16, 2023 04:08
@yuzefovich yuzefovich requested review from michae2 and removed request for a team August 16, 2023 04:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @michae2)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 16, 2023

Build succeeded:

@craig craig bot merged commit 75c6056 into cockroachdb:master Aug 16, 2023
@yuzefovich yuzefovich deleted the range-cache branch August 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants