kvserver: enable replicate enqueue on span cfg updates by default #108799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TestProtectedTimestamp` test previously used a test cluster with 3 nodes, after 0147fcc, the test only uses a single node. Update the helper function for finding a replica, to expect just 1 server. Epic: none Release note: None
Replicas were enqueued into the replicate queue, upon the store receiving a span config update which could affect the replica. The replicate queue shouldQueue is relatively more expensive than other queues. Introduce the cluster setting kv.enqueue_in_replicate_queue_on_span_config_update.enabled, which when set to true, enables queuing up replicas on span config updates; when set to false, disables queuing replicas on span config updates. By default, this settings is set to false. Resolves: cockroachdb#108724 Release note (ops change): Introduce the kv.enqueue_in_replicate_queue_on_span_config_update.enabled cluster setting. When set to true, stores in the cluster will enqueue replicas for replication changes, upon receiving config updates which could affect the replica. This setting is off by default. Enabling this setting speeds up how quickly config triggered replication changes begin, but adds additional CPU overhead. The overhead scales with the number of leaseholders.
`kv.enqueue_in_replicate_queue_on_span_config_update.enabled` controls whether replicas are enqueued into the replicate queue, upon a span config update. The setting was disabled due to overhead. Re-enable the setting, as we anticipate significantly reducing the overhead in Informs: cockroachdb#108795 Release note (ops change): Enable `kv.enqueue_in_replicate_queue_on_span_config_update.enabled` by default. This setting speeds up how quickly replication changes begin, after changing a related configuration e.g. database primary region or replication factor.
kvoli
changed the title
|
This change is |
|
Closing in favor of #108809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/3 commits from #108725
kv.enqueue_in_replicate_queue_on_span_config_update.enabled` controls
whether replicas are enqueued into the replicate queue, upon a span
config update. The setting was disabled due to overhead. Re-enable the
setting, as we anticipate significantly reducing the overhead in
Informs: #108795
Release note (ops change): Enable
kv.enqueue_in_replicate_queue_on_span_config_update.enabledby default. This setting speeds up how quickly replication changes
begin, after changing a related configuration e.g. database primary
region or replication factor.