Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: allow stats mismatches in clearrange roachtest #108786

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

itsbilal
Copy link
Member

Previously, the clearrange roachtest was the only place anywhere in the CockroachDB codebase where we would assert on MVCC stats matching between replicas. This would trip up and fail the clearrange roachtest even in known cases of MVCC stats mismatches. This change removes the code to assert on stats mismatches with consistency checks, but retains the clearrange roachtest's use of aggressive consistency checks, so mismatches in checksums computed on data in each replica will continue to fatal the test.

Related to #93896.

Fixes #108726.

Epic: none

Release note: None

Previously, the clearrange roachtest was the only place anywhere in
the CockroachDB codebase where we would assert on MVCC stats matching
between replicas. This would trip up and fail the clearrange roachtest
even in known cases of MVCC stats mismatches. This change removes the
code to assert on stats mismatches with consistency checks, but retains
the clearrange roachtest's use of aggressive consistency checks, so
mismatches in checksums computed on data in each replica will
continue to fatal the test.

Related to cockroachdb#93896.

Fixes cockroachdb#108726.

Epic: none

Release note: None
@itsbilal itsbilal requested review from a team and sumeerbhola August 15, 2023 17:32
@itsbilal itsbilal requested a review from a team as a code owner August 15, 2023 17:32
@itsbilal itsbilal requested a review from a team August 15, 2023 17:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@itsbilal
Copy link
Member Author

TFTR!

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Aug 15, 2023

Build failed:

@itsbilal
Copy link
Member Author

bors retry

@craig
Copy link
Contributor

craig bot commented Aug 16, 2023

Build succeeded:

@craig craig bot merged commit 35e72b8 into cockroachdb:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: clearrange/zfs/checks=true failed
3 participants