roachtest/costfuzz: create failure.log file on demand #108739
Conversation
yuzefovich
requested review from
rachitgsrivastava and
DarrylWong
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Nice fix!
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @michae2 and @yuzefovich)
pkg/cmd/roachtest/tests/query_comparison_util.go line 168 at r1 (raw file):
} }() defer failureLog.Close()
Should this line be removed because now failureLog might be nil and the deferred function is doing the closing?
This commit makes it so that `failure.log` files are created lazily on demand in `costfuzz` and `unoptimized_query_oracle` roachtests. It seems nicer this way since for successful runs previously we'd see empty failure log files which were a bit confusing. Epic: None Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/query_comparison_util.go line 168 at r1 (raw file):
Previously, msirek (Mark Sirek) wrote…
Should this line be removed because now
failureLogmight be nil and the deferred function is doing the closing?
Oops, nice catch, thanks.
There was a problem hiding this comment.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
This commit makes it so that
failure.logfiles are created lazily on demand incostfuzzandunoptimized_query_oracleroachtests. It seems nicer this way since for successful runs previously we'd see empty failure log files which were a bit confusing.Epic: None
Release note: None