Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlccl: remove base.TODOTestTenantDisabled #108721

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

yuzefovich
Copy link
Member

In all of the touched tests we control the tenants explicitly. Also add some log scopes.

Informs: #76378.
Epic: CRDB-18499.

Release note: None

In all of the touched tests we control the tenants explicitly. Also add
some log scopes.

Release note: None
@yuzefovich yuzefovich requested review from knz and stevendanna August 14, 2023 16:52
@yuzefovich yuzefovich requested a review from a team as a code owner August 14, 2023 16:52
@yuzefovich yuzefovich requested a review from DrewKimball August 14, 2023 16:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich removed request for a team and DrewKimball August 14, 2023 16:52
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 14, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 14, 2023

Build succeeded:

@craig craig bot merged commit e7571f3 into cockroachdb:master Aug 14, 2023
@yuzefovich yuzefovich deleted the testccl branch August 14, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants