tests: rename StartNewTestCluster to StartCluster
#108636
Conversation
knz
requested review from
ericharmeling,
lidorcarmel and
samiskin
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 88 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz)
-- commits line 6 at r1:
nit: s/searc/search/.
pkg/testutils/testcluster/testcluster.go line 570 at r1 (raw file):
serverArgs.NoAutoInitializeCluster = true } // Check args even though they might have been checked in New/Start;
nit: I think something is off here.
This follows for symmetry with `StartServer`. This is a simple search-replace substitution: `serverutils.StartNewTestCluster` -> `serverutils.StartCluster` Release note: None
There was a problem hiding this comment.
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
s/searc/search/.
Fixed.
pkg/testutils/testcluster/testcluster.go line 570 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: I think something is off here.
Clarified.
knz
force-pushed
the
20230807-simplify-tc-name
branch
from
d1b9134 to
05d3fa0
Compare
|
TFYR! bors r=yuzefovich |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Part of #107986.
Epic: CRDB-18499
This follows for symmetry with
StartServer.This is a simple searc-replace substitution:
serverutils.StartNewTestCluster->serverutils.StartClusterRelease note: None