Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: Restrict SQL activity logging by user/role doc update #108623

Merged
merged 1 commit into from
Oct 6, 2023
Merged

docgen: Restrict SQL activity logging by user/role doc update #108623

merged 1 commit into from
Oct 6, 2023

Conversation

nickvigilante
Copy link
Contributor

Fixes DOC-8560

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented Aug 11, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

worth getting a review from someone on docs as well

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nickvigilante)

Copy link

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickvigilante nickvigilante marked this pull request as ready for review October 6, 2023 21:08
@nickvigilante nickvigilante requested review from a team and abarganier and removed request for a team October 6, 2023 21:08
@nickvigilante
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 6, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 6, 2023

Build succeeded:

@craig craig bot merged commit c5474dd into cockroachdb:master Oct 6, 2023
@nickvigilante nickvigilante deleted the doc-8560 branch October 9, 2023 13:55
@nickvigilante
Copy link
Contributor Author

blathers backport 23.1 23.2

@blathers-crl
Copy link

blathers-crl bot commented Oct 9, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error getting backport branch release-23.2: unexpected status code: 404 Not Found

Backport to branch 23.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants