Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/sem/builtins: add TestGenerateUniqueUnorderedIDOrder #108474

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Aug 9, 2023

This patch adds a new TestGenerateUniqueUnorderedIDOrder test to verify that IDs produced by GenerateUniqueUnorderedID are indeed unordered.

Epic: None

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the generate_unordered_test_2 branch 2 times, most recently from a27dea9 to 3f33a91 Compare August 9, 2023 19:54
@andyyang890 andyyang890 marked this pull request as ready for review August 9, 2023 20:28
@andyyang890 andyyang890 requested a review from a team as a code owner August 9, 2023 20:28
@andyyang890 andyyang890 requested a review from rafiss August 9, 2023 20:29
This patch adds a new TestGenerateUniqueUnorderedIDOrder test to verify
that IDs produced by GenerateUniqueUnorderedID are indeed unordered.

Release note: None
@andyyang890 andyyang890 force-pushed the generate_unordered_test_2 branch from 3f33a91 to 47d8bd5 Compare August 9, 2023 22:35
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice test!

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Aug 12, 2023

Build succeeded:

@craig craig bot merged commit 7da4ef5 into cockroachdb:master Aug 12, 2023
@andyyang890 andyyang890 deleted the generate_unordered_test_2 branch August 12, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants