Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "kvprober: metamorphically enable / configure kvprober" #108454

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Revert "kvprober: metamorphically enable / configure kvprober" #108454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/kv/kvprober/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ go_library(
"//pkg/roachpb",
"//pkg/settings",
"//pkg/settings/cluster",
"//pkg/util",
"//pkg/util/log",
"//pkg/util/log/logcrash",
"//pkg/util/metric",
Expand Down
12 changes: 5 additions & 7 deletions pkg/kv/kvprober/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ import (
"time"

"github.com/cockroachdb/cockroach/pkg/settings"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/errors"
)

var defaultEnabled = util.ConstantWithMetamorphicTestBool("kv.prober.*.enabled", false)

// kv.prober.bypass_admission_control controls whether kvprober's requests
// should bypass kv layer's admission control. Setting this value to true
// ensures that kvprober will not be significantly affected if the cluster is
Expand All @@ -30,13 +27,14 @@ var bypassAdmissionControl = settings.RegisterBoolSetting(
"set to bypass admission control queue for kvprober requests; "+
"note that dedicated clusters should have this set as users own capacity planning "+
"but serverless clusters should not have this set as SREs own capacity planning",
util.ConstantWithMetamorphicTestBool("kv.prober.bypass_admission_control.enabled", true))
true,
)

var readEnabled = settings.RegisterBoolSetting(
settings.TenantWritable,
"kv.prober.read.enabled",
"whether the KV read prober is enabled",
defaultEnabled)
false)

// TODO(josh): Another option is for the cluster setting to be a QPS target
// for the cluster as a whole.
Expand Down Expand Up @@ -72,7 +70,7 @@ var writeEnabled = settings.RegisterBoolSetting(
settings.TenantWritable,
"kv.prober.write.enabled",
"whether the KV write prober is enabled",
defaultEnabled)
false)

var writeInterval = settings.RegisterDurationSetting(
settings.TenantWritable,
Expand Down Expand Up @@ -150,7 +148,7 @@ var quarantineWriteEnabled = settings.RegisterBoolSetting(
"quarantine pool holds a separate group of ranges that have previously failed "+
"a probe which are continually probed. This helps determine outages for ranges "+
" with a high level of confidence",
defaultEnabled)
false)

var quarantineWriteInterval = settings.RegisterDurationSetting(
settings.TenantWritable,
Expand Down