release-23.1: sql: add extra information to protocol errors in bind #108453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cucaroach
changed the title
Release note: None
A user is running into mysterious protocol errors when using prepared statements. Add some extra information to the error message to help guide the investigation. Informs: https://github.com/cockroachlabs/support/issues/2184 Release note: none Epic: none
cucaroach
force-pushed
the
backport-106130
branch
from
139e846 to
63eafcf
Compare
|
Now that we have a repro (in https://github.com/cockroachlabs/support/issues/2510) for the same bug as https://github.com/cockroachlabs/support/issues/2184, is it still worth backporting it? |
I don't feel strongly either way, I'll defer to @rafiss |
|
I'm fine to skip the backport. Since we don't have a need for it right now, it doesn't seem worth the general risk of even a light refactor/conflict fix that was needed for the backport. |
ecwall
approved these changes
Aug 14, 2023
|
Closing based on Rafi's feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport is a clean cherry pick of b0ab077 from #103857 and #106130 with a pkgwire --rewrite to pick up some DD test changes.
sql: add extra information to protocol errors in bind
A user is running into mysterious protocol errors when using prepared
statements. Add some extra information to the error message to help
guide the investigation.
Informs: https://github.com/cockroachlabs/support/issues/2184
Release note: none
Epic: none
pgwire: include detail and hint in error tests
Release note: None
Release justification: Low risk change that just adds additional information to error paths seen in support issues.