Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: deflake npgsql test #108415

Merged
merged 1 commit into from
Aug 10, 2023
Merged

roachtest: deflake npgsql test #108415

merged 1 commit into from
Aug 10, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 9, 2023 •
edited
Loading

These upstream tests are flaky, so we ignore them.

informs #108414
fixes #108044
fixes #108504
Release note: None

@rafiss rafiss requested a review from a team August 9, 2023 04:44
@rafiss rafiss requested a review from a team as a code owner August 9, 2023 04:44
@rafiss rafiss requested review from rachitgsrivastava and DarrylWong and removed request for a team August 9, 2023 04:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
roachtest: deflake npgsql test
4cf794e 
These upstream tests are flaky, so we ignore them.

Release note: None
@rafiss rafiss added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 10, 2023
@rafiss rafiss requested a review from andyyang890 August 10, 2023 14:01
fqazi
fqazi approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andyyang890, @DarrylWong, and @rachitgsrivastava)

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 10, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build succeeded:

@craig craig bot merged commit 618c73a into cockroachdb:master Aug 10, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from 4cf794e to blathers/backport-release-23.1-108415: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss mentioned this pull request Aug 11, 2023
Merged
@rafiss rafiss deleted the deflake-npgsql branch August 14, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi fqazi approved these changes

@rachitgsrivastava rachitgsrivastava Awaiting requested review from rachitgsrivastava rachitgsrivastava was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

@andyyang890 andyyang890 Awaiting requested review from andyyang890

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: npgsql failed roachtest: npgsql failed
3 participants
@rafiss @cockroach-teamcity @fqazi