-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: kvserver: deflake lease preferences during outage #108362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-108333
branch
from
August 8, 2023 15:55
ad08ff5
to
b98fb90
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Aug 8, 2023
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-108333
branch
from
August 8, 2023 15:55
95ed512
to
85dfc58
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
erikgrinaker
approved these changes
Aug 8, 2023
Previously, it was possible for a soon to be dead replica, to acquire the range lease in the `TestLeasePreferencesDuringOutage` test. The acquired lease would be expiration based, disallowing the intended leaseholder from acquiring the lease. This patch disables expiration based lease transfers, deflaking the test. Resolves: #105101 Epic: none Release note: None
kvoli
force-pushed
the
blathers/backport-release-23.1-108333
branch
from
August 8, 2023 17:08
85dfc58
to
8d620f9
Compare
@erikgrinaker I made a slight change from master |
SGTM |
TYFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #108333 on behalf of @kvoli.
/cc @cockroachdb/release
This PR is intended to be backported to
release-22.2
.TestLeasePreferencesDuringOutage
is currently skipped on master.Stressed for 30 mins without failure on release-22.2.
Previously, it was possible for a soon-to-be dead replica, to acquire the range lease in the
TestLeasePreferencesDuringOutage
test. The acquired lease would be expiration based, disallowing the intended leaseholder from acquiring the lease.This patch disables expiration based lease transfers, deflaking the test.
Resolves: #105101
Epic: none
Release note: None
Release justification: Test only change.