Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: kvserver: deflake lease preferences during outage #108361

Merged
merged 1 commit into from
Aug 8, 2023
Merged

release-22.2: kvserver: deflake lease preferences during outage #108361

merged 1 commit into from
Aug 8, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 8, 2023 •
edited by kvoli
Loading

Backport 1/1 commits from #108333 on behalf of @kvoli.

/cc @cockroachdb/release

This PR is intended to be backported to release-22.2.
TestLeasePreferencesDuringOutage is currently skipped on master.
Stressed for 30 mins without failure on release-22.2.

Previously, it was possible for a soon-to-be dead replica, to acquire the range lease in the TestLeasePreferencesDuringOutage test. The acquired lease would be expiration based, disallowing the intended leaseholder from acquiring the lease.

This patch disables expiration based lease transfers, deflaking the test.

Resolves: #105101
Epic: none

Release note: None

Release justification: Test only change.

@blathers-crl blathers-crl bot requested a review from a team as a code owner August 8, 2023 15:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-108333 branch from ab78d10 to 1c6c29d Compare August 8, 2023 15:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 8, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 8, 2023 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-108333 branch from 5a4d33e to c84b728 Compare August 8, 2023 15:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

erikgrinaker
erikgrinaker approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we fix the non-existant setting.

@kvoli
kvserver: deflake lease preferences during outage
e5d92dd 
Previously, it was possible for a soon to be dead replica, to acquire
the range lease in the `TestLeasePreferencesDuringOutage` test. The
acquired lease would be expiration based, disallowing the intended
leaseholder from acquiring the lease.

This patch disables expiration based lease transfers, deflaking the
test.

Resolves: #105101
Epic: none

Release note: None
@kvoli kvoli force-pushed the blathers/backport-release-22.2-108333 branch from c84b728 to e5d92dd Compare August 8, 2023 17:11
@kvoli
Copy link
Collaborator

kvoli commented Aug 8, 2023

LGTM once we fix the non-existant setting.

Done

TYFTR!

@kvoli kvoli merged commit a997d3c into release-22.2 Aug 8, 2023
@kvoli kvoli deleted the blathers/backport-release-22.2-108333 branch August 8, 2023 19:47
@kvoli kvoli mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@aliher1911 aliher1911 Awaiting requested review from aliher1911

Assignees

@kvoli kvoli

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @kvoli @erikgrinaker