Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use [email protected] via Bazel #108329

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

sjbarag
Copy link
Contributor

@sjbarag sjbarag commented Aug 7, 2023

Commit f7a8aa2 (ui: upgrade typescript from v4 to v5, 2023-08-03) recently upgraded to TypeScript 5.1.6. Keep the version used by rules_ts in-sync.

Epic: none
Release note: None

@sjbarag sjbarag requested a review from rickystewart August 7, 2023 21:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Commit f7a8aa2 (ui: upgrade typescript from v4 to v5, 2023-08-03)
recently upgraded to TypeScript 5.1.6. Keep the version used by rules_ts
in-sync.

Epic: none
Release note: None
@sjbarag sjbarag force-pushed the use-typescript-5-via-bazel-too branch from 9e8413e to 71e7a50 Compare August 7, 2023 21:36
@sjbarag
Copy link
Contributor Author

sjbarag commented Aug 7, 2023

Whoops, 5.1.6 is too new for any version of rules_ts so I had to add an integrity string.

@sjbarag
Copy link
Contributor Author

sjbarag commented Aug 7, 2023

bors r=rickystewart

@craig
Copy link
Contributor

craig bot commented Aug 7, 2023

Build succeeded:

@craig craig bot merged commit 8c1ff51 into cockroachdb:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants