release-22.2: sql: fix CREATE AS [SHOW CREATE FUNCTION] job failure #108167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes debugging easier by including the invalid JSON in that caused JSONBMarshalToMessage to fail. Release note: None
…ssageToJSON Fixes #107823 This PR makes `VectorizeExecMode`'s protobuf and JSON string representations the same to prevent errors like this when `SessionData.VectorizeMode` has a non-zero value: ``` unknown value "on" for enum cockroach.sql.sessiondatapb.VectorizeExecMode ``` Release note: None
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
ecwall
requested review from
rafiss
and removed request for
a team and
yuzefovich
|
This change is |
Fixes #106268 Previously `CREATE TABLE AS`/`CREATE MATERIALIZED VIEW AS` sourcing from `SHOW CREATE FUNCTION <function>` generated a failing schema change job with a `unknown function: f(): function undefined` error because the job runs in the system database and functions cannot be referenced cross database. This PR fixes this by using the original user session (which includes the database) in the schema change job. Release note (bug fix): Fixes the schema changer job when CREATE AS sources from SHOW CREATE FUNCTION: CREATE TABLE t AS SELECT * FROM [SHOW CREATE FUNCTION f];
Xiang-Gu
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #107567.
/cc @cockroachdb/release
Fixes #106268
Previously
CREATE TABLE AS/CREATE MATERIALIZED VIEW ASsourcing fromSHOW CREATE FUNCTION <function>generated a failing schema change job with aunknown function: f(): function undefinederror because the job runs in the system database and functions cannot be referenced cross database.This PR fixes this by using the original user session (which includes the database) in the schema change job.
Release note (bug fix): Fixes the schema changer job when CREATE AS sources from SHOW CREATE FUNCTION:
CREATE TABLE t AS SELECT * FROM [SHOW CREATE FUNCTION f];
Release justification: CREATE AS bug fix.