release-23.1: sql: fix CREATE AS [SHOW CREATE FUNCTION] job failure #108161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues Release note: None
Release note: None
Release note: None
Release note: None
After changing the sessiondata to stop using zero-value defaults, a test started failing. It works when using a zero sessiondata, which deserves more investigation. Release note: None
Prevent zero-values from being used for session vars when creating an InternalDB. Release note: None
Now that the internal executor is using a non-zero session data, that means it uses the declarative schema changer by default. The upgrade manager had a few assumptions in it that were specific to the old schema changer: - The PGAttributeNum field should only be set if it differs from the column descriptor ID. - Check the DeclarativeSchemaChangerState when waiting for migrations to finish. Release note: None
This change makes debugging easier by including the invalid JSON in that caused JSONBMarshalToMessage to fail. Release note: None
…ssageToJSON Fixes #107823 This PR makes `VectorizeExecMode`'s protobuf and JSON string representations the same to prevent errors like this when `SessionData.VectorizeMode` has a non-zero value: ``` unknown value "on" for enum cockroach.sql.sessiondatapb.VectorizeExecMode ``` Release note: None
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
ecwall
requested review from
rhu713,
jayshrivastava,
nkodali and
mgartner
and removed request for
a team
|
This change is |
ecwall
requested review from
rafiss
and removed request for
mgartner,
a team and
rhu713
Fixes #106268 Previously `CREATE TABLE AS`/`CREATE MATERIALIZED VIEW AS` sourcing from `SHOW CREATE FUNCTION <function>` generated a failing schema change job with a `unknown function: f(): function undefined` error because the job runs in the system database and functions cannot be referenced cross database. This PR fixes this by using the original user session (which includes the database) in the schema change job. Release note (bug fix): Fixes the schema changer job when CREATE AS sources from SHOW CREATE FUNCTION: CREATE TABLE t AS SELECT * FROM [SHOW CREATE FUNCTION f];
|
Backporting #101486 seems scary, and to me the bug with CREATE AS [SHOW CREATE FUNCTION] doesn't seem worth the risk, so I'd vote to not merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: CREATE AS bug fix.