Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest/awsdms: run once a week instead #108160

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

otan
Copy link
Contributor

@otan otan commented Aug 4, 2023

Save a bit of mad dosh by running awsdms once a weekly instead of daily. We don't need this tested every week.

Epic: None

Release note: None

@otan otan added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 4, 2023
@otan otan requested a review from Jeremyyang920 August 4, 2023 11:08
@otan otan requested a review from a team as a code owner August 4, 2023 11:08
@otan otan requested review from herkolategan and smg260 and removed request for a team August 4, 2023 11:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@@ -192,7 +192,7 @@ func registerAWSDMS(r registry.Registry) {
Owner: registry.OwnerMigrations,
Cluster: r.MakeClusterSpec(1),
Leases: registry.MetamorphicLeases,
Tags: registry.Tags(`default`, `awsdms`, `aws`),
Tags: registry.Tags(`default`, `awsdms`, `aws`, `weekly`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only 2 tags required here are weekly and aws-weekly. The former gets special treatment in roachtest [1], and the latter is required to actually run it in the weekly aws job.

[1] - test_registry.go
[2] - roachtest_weekly_aws_impl.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! amended.

Save a bit of mad dosh by running awsdms once a weekly instead of daily.
We don't need this tested every week.

Epic: None

Release note: None
@otan
Copy link
Contributor Author

otan commented Aug 8, 2023

bors r=Jeremyyang920

@craig craig bot merged commit 69bc4c6 into cockroachdb:master Aug 8, 2023
@craig
Copy link
Contributor

craig bot commented Aug 8, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Aug 8, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from b5e2041 to blathers/backport-release-22.2-108160: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from b5e2041 to blathers/backport-release-23.1-108160: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants