-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest/awsdms: run once a week instead #108160
Conversation
pkg/cmd/roachtest/tests/awsdms.go
Outdated
@@ -192,7 +192,7 @@ func registerAWSDMS(r registry.Registry) { | |||
Owner: registry.OwnerMigrations, | |||
Cluster: r.MakeClusterSpec(1), | |||
Leases: registry.MetamorphicLeases, | |||
Tags: registry.Tags(`default`, `awsdms`, `aws`), | |||
Tags: registry.Tags(`default`, `awsdms`, `aws`, `weekly`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only 2 tags required here are weekly
and aws-weekly
. The former gets special treatment in roachtest [1], and the latter is required to actually run it in the weekly aws job.
[1] - test_registry.go
[2] - roachtest_weekly_aws_impl.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! amended.
Save a bit of mad dosh by running awsdms once a weekly instead of daily. We don't need this tested every week. Epic: None Release note: None
bors r=Jeremyyang920 |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b5e2041 to blathers/backport-release-22.2-108160: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from b5e2041 to blathers/backport-release-23.1-108160: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Save a bit of mad dosh by running awsdms once a weekly instead of daily. We don't need this tested every week.
Epic: None
Release note: None