Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: upgrade typescript from v4 to v5 #108147

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Aug 3, 2023

Upgrade Typescript from v4 to v5, that has a smaller size, is faster and adds new features.

This commit make some updates that were causing errors
on the new Typescript version, such as type mismatch error. [1]

[1] https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#forbidden-implicit-coercions-in-relational-operators
Epic: none

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag force-pushed the upgrade-typescript branch from 8ffe1bf to 24335d7 Compare August 3, 2023 22:22
Upgrade Typescript from v4 to v5, that have a smaller
size, is faster and adds new features.

This commit make some updates that were causing errors
on the new Typescript version, such as type mismatch error.

Epic: none

Release note: None
@maryliag maryliag force-pushed the upgrade-typescript branch from 24335d7 to f7a8aa2 Compare August 3, 2023 23:20
@maryliag maryliag requested a review from a team August 4, 2023 00:32
@maryliag maryliag marked this pull request as ready for review August 4, 2023 00:33
@maryliag maryliag requested review from a team, nathanstilwell and sjbarag August 4, 2023 00:33
Copy link
Contributor

@nathanstilwell nathanstilwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm honestly surprised it was this easy. 😄

Copy link
Contributor

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this, @maryliag 🎉

@maryliag
Copy link
Contributor Author

maryliag commented Aug 4, 2023

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 4, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 4, 2023

Build succeeded:

@craig craig bot merged commit 7a597b6 into cockroachdb:master Aug 4, 2023
@maryliag maryliag deleted the upgrade-typescript branch August 4, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants