Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: deflake TestChangefeedSchemaChangeBackfillCheckpoint #108143

Conversation

jayshrivastava
Copy link
Contributor

When using the declarative schema changer, we should refresh the span to assert at the end because it may change due to a primary index swap during the schema change.

Release note: None
Fixes: #108084
Epic: None

When using the declarative schema changer, we should refresh
the span to assert at the end because it may change
due to a primary index swap during the schema change.

Release note: None
Fixes: cockroachdb#108084
Epic: None
@jayshrivastava jayshrivastava requested a review from a team as a code owner August 3, 2023 20:51
@jayshrivastava jayshrivastava requested review from miretskiy and removed request for a team August 3, 2023 20:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jayshrivastava
Copy link
Contributor Author

bors r=miretskiy

@craig
Copy link
Contributor

craig bot commented Aug 3, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 3, 2023

Build succeeded:

@craig craig bot merged commit a20cf2d into cockroachdb:master Aug 3, 2023
@jayshrivastava jayshrivastava deleted the debug-TestChangefeedSchemaChangeBackfillCheckpoint branch August 4, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedSchemaChangeBackfillCheckpoint failed
3 participants