Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Add rangefeed metrics #108062

Merged
merged 2 commits into from
Aug 3, 2023
Merged

server: Add rangefeed metrics #108062

merged 2 commits into from
Aug 3, 2023

Conversation

miretskiy
Copy link
Contributor

Add rangefeed related metrics to keep track of the number of actively running rangefeeds on the server.

Epic: CRDB-26372
Release note: None

@miretskiy miretskiy requested a review from erikgrinaker August 2, 2023 20:46
@miretskiy miretskiy requested review from a team as code owners August 2, 2023 20:46
@blathers-crl
Copy link

blathers-crl bot commented Aug 2, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/server/node.go Outdated Show resolved Hide resolved
pkg/server/node.go Outdated Show resolved Hide resolved
pkg/server/node.go Outdated Show resolved Hide resolved
pkg/server/node.go Outdated Show resolved Hide resolved
Yevgeniy Miretskiy added 2 commits August 3, 2023 10:20
Add rangefeed related metrics to keep track of the
number of actively running rangefeeds on the server.

Epic: CRDB-26372
Release note: None
Annotate `DistSenderRangeFeedMetrics` as `metric.Struct`
in order to register those metrics with metrics registry.

Issue: None
Release note: None
@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 3, 2023

Build succeeded:

@craig craig bot merged commit b9f3f15 into cockroachdb:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants