Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: always log store rebalancer transfers and relocates #108054

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Aug 2, 2023

Previously, the store rebalancer would not default log range lease transfers or replica relocations, nor their estimated load impact. This made debugging imbalance related issues difficult.

Bump the range relocation and range lease transfer log lines from v(1) to Info, so that they are always logged.

Resolves: #107702

Release note: None

@kvoli kvoli added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 2, 2023
@kvoli kvoli self-assigned this Aug 2, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 2, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the store rebalancer would not default log range lease
transfers or replica relocations, nor their estimated load impact. This
made debugging imbalance related issues difficult.

Bump the range relocation and range lease transfer log lines from
`v(1)` to `Info`, so that they are always logged.

Resolves: cockroachdb#107702

Release note: None
@kvoli kvoli force-pushed the 230802.sr-bump-log-verbosity branch from a59ebe9 to 7f5ffa5 Compare August 3, 2023 13:13
@kvoli kvoli marked this pull request as ready for review August 3, 2023 15:02
@kvoli kvoli requested a review from a team as a code owner August 3, 2023 15:02
@kvoli kvoli requested a review from andrewbaptist August 3, 2023 15:16
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kvoli
Copy link
Collaborator Author

kvoli commented Aug 7, 2023

TYFTR!

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Aug 7, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver: store rebalancer lease transfers don't log which range the transfer was for or the impact
3 participants