server: unexport Server #108010
server: unexport Server #108010
Conversation
|
This change is |
knz
force-pushed
the
20230802-unexport-server
branch
2 times, most recently
from
8a59e39 to
340374f
Compare
knz
requested review from
herkolategan,
smg260,
nkodali,
stevendanna and
yuzefovich
and removed request for
a team
There was a problem hiding this comment.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @knz, @nkodali, @smg260, and @stevendanna)
pkg/server/serverctl/api.go line 59 at r1 (raw file):
} // serverShutdownInterface is the subset of the APIs on a server
nit: s/serverShutdownInterface/ServerShutdownInterface/.
pkg/server/serverctl/api.go line 68 at r1 (raw file):
// ShutdownRequest is used to signal a request to shutdown the server through // stopTrigger. It carries the reason for the shutdown.
nit: stopTrigger is no longer next to this struct, perhaps do server.stopTrigger or reword the comment?
We should really only look at top level servers through an interface. Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/server/serverctl/api.go line 59 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
s/serverShutdownInterface/ServerShutdownInterface/.
Done.
pkg/server/serverctl/api.go line 68 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
stopTriggeris no longer next to this struct, perhaps doserver.stopTriggeror reword the comment?
Done.
knz
force-pushed
the
20230802-unexport-server
branch
from
340374f to
d9f6b1a
Compare
|
TFYR! bors r=yuzefovich |
|
Build succeeded: |
We should really look at top level servers through an interface.
Epic: CRDB-28893