Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest: require stability in rebalance by load roachtests #108000

Merged
merged 2 commits into from
Aug 2, 2023
Merged

release-23.1: roachtest: require stability in rebalance by load roachtests #108000

merged 2 commits into from
Aug 2, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 2, 2023 •
edited by kvoli
Loading

Backport 2/2 commits from #107834 on behalf of @kvoli.

/cc @cockroachdb/release

The rebalance/by-load roachtests collect timeseries data from the
cluster. If these tests started quickly enough, no datapoints could
exist which would cause a out of bounds array exception.

Handle the no datapoints case, and log a message without failing the
test.

Informs: #107247

The rebalance/by-load roachtests would immediately pass once the
balance target was hit. However, it was possible that the cluster was
only transiently balanced.

Bump the timeout of all tests to be uniformly 10 minutes, from a
previous 5 minutes, require that the load remains balanced for at
least 1 minute to pass.

Informs: #107247

Release note: None

Release justification: roachtest only change.

kvoli added 2 commits July 28, 2023 20:58
@kvoli
roachtest: handle no ts datapoints in rebalance by-load roachtests
815f200 
The `rebalance/by-load` roachtests collect timeseries data from the
cluster. If these tests started quickly enough, no datapoints could
exist which would cause an out of bounds array error.

Handle the no datapoints case, and log a message without failing the
test.

Informs: #107247

Release note: None
@kvoli
roachtest: wait for stability in rebalance load
b354ffe 
The `rebalance/by-load` roachtests would immediately pass once the
balance target was hit. However, it was possible that the cluster was
only transiently balanced.

Bump the timeout of all tests to be uniformly 10 minutes, from a
previous 5-10 minutes, require that the load remains balanced for at
least 1 minute to pass.

Informs: #107247

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 2, 2023 00:53
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107834 branch from 8003184 to 815f200 Compare August 2, 2023 00:53
@blathers-crl blathers-crl bot requested review from herkolategan and srosenberg and removed request for a team August 2, 2023 00:53
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 2, 2023 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 2, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107834 branch 2 times, most recently from 815f200 to 6f09c90 Compare August 2, 2023 00:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

andrewbaptist
andrewbaptist approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@kvoli
Copy link
Collaborator

kvoli commented Aug 2, 2023

TYFTR!

@kvoli kvoli merged commit 304bb4c into release-23.1 Aug 2, 2023
@kvoli kvoli deleted the blathers/backport-release-23.1-107834 branch August 2, 2023 20:05
@kvoli kvoli mentioned this pull request Aug 2, 2023
Closed
@kvoli kvoli linked an issue Aug 2, 2023 that may be closed by this pull request
roachtest: rebalance/by-load/replicas/mixed-version failed #107247
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbaptist andrewbaptist andrewbaptist approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

@kvoli kvoli Awaiting requested review from kvoli

@renatolabs renatolabs Awaiting requested review from renatolabs

@smg260 smg260 Awaiting requested review from smg260

@sumeerbhola sumeerbhola Awaiting requested review from sumeerbhola

Assignees

@kvoli kvoli

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: rebalance/by-load/replicas/mixed-version failed
3 participants
@cockroach-teamcity @kvoli @andrewbaptist