Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: do not generate docs for crdb_internal functions #107962

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 1, 2023

Epic: None
Release note: None

@rafiss rafiss requested a review from a team August 1, 2023 17:28
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from knz August 3, 2023 15:55
@rafiss
Copy link
Collaborator Author

rafiss commented Aug 3, 2023

tftr!

bors r=knz

@rafiss rafiss added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 3, 2023
@craig
Copy link
Contributor

craig bot commented Aug 3, 2023

Build succeeded:

@craig craig bot merged commit b9f3f15 into cockroachdb:master Aug 3, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 846c348 to blathers/backport-release-22.2-107962: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from 846c348 to blathers/backport-release-23.1-107962: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss deleted the no-doc-crdb_internal branch August 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants