Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: export distsender metrics from SQL pods #107956

Conversation

nvanbenschoten
Copy link
Member

This commit exports the DistSender timeseries metrics from SQL pods.

distsender.batches
distsender.batches.partial
distsender.batch_requests.replica_addressed.bytes
distsender.batch_responses.replica_addressed.bytes
distsender.batch_requests.cross_region.bytes
distsender.batch_responses.cross_region.bytes
distsender.batch_requests.cross_zone.bytes
distsender.batch_responses.cross_zone.bytes
distsender.batches.async.sent
distsender.batches.async.throttled
distsender.rpc.sent
distsender.rpc.sent.local
distsender.rpc.sent.nextreplicaerror
distsender.errors.notleaseholder
distsender.errors.inleasetransferbackoffs
distsender.rangelookups
requests.slow.distsender
distsender.rpc.%s.sent # rpc name
distsender.rpc.err.%s  # error name
distsender.rangefeed.total_ranges
distsender.rangefeed.catchup_ranges
distsender.rangefeed.error_catchup_ranges
distsender.rangefeed.restart_ranges
distsender.rangefeed.restart_stuck

Epic: None
Release note: None

This commit exports the DistSender timeseries metrics from SQL pods.

Epic: None
Release note: None
@nvanbenschoten nvanbenschoten requested review from knz and a team August 1, 2023 15:57
@nvanbenschoten nvanbenschoten requested review from a team as code owners August 1, 2023 15:57
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 1, 2023
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)

@nvanbenschoten
Copy link
Member Author

bors r=knz

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 2, 2023

Timed out.

@nvanbenschoten
Copy link
Member Author

bors r=knz

@craig
Copy link
Contributor

craig bot commented Aug 2, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 2, 2023

Build succeeded:

@craig craig bot merged commit 9355e10 into cockroachdb:master Aug 2, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/exportDistSenderMetrics branch August 3, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants