testutils: fix determinism in random predecessor history tests #107950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `rng` instance used by the tests was initialized once in the `var` block. That meant that every assertion that relied on that rng was order-dependent: running a single test in that file in isolation would lead to failed assertions. This commit ensures that every test resets the rng before making any assertions, guaranteeing we get the same values regardless of execution order. Epic: none Release note: None
renatolabs
requested review from
jayshrivastava,
a team,
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
jayshrivastava
approved these changes
Aug 1, 2023
|
TFTR! bors r=jayshrivastava |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
rnginstance used by the tests was initialized once in thevarblock. That meant that every assertion that relied on that rng was order-dependent: running a single test in that file in isolation would lead to failed assertions.This commit ensures that every test resets the rng before making any assertions, guaranteeing we get the same values regardless of execution order.
Epic: none
Release note: None