Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: don't import testing for DisableMetamorphicSimpleValueEncoding #107941

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

erikgrinaker
Copy link
Contributor

We shouldn't link testing in binaries.

Epic: none
Release note: None

…oding`

We shouldn't link `testing` in binaries.

Epic: none
Release note: None
@erikgrinaker erikgrinaker self-assigned this Aug 1, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner August 1, 2023 12:52
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@erikgrinaker erikgrinaker added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

@rickystewart Didn't we use to lint against importing certain packages in production code?

@rickystewart
Copy link
Collaborator

@rickystewart Didn't we use to lint against importing certain packages in production code?

"Technically", the test existed and was deleted by me. Due to bitrot the assertion broke years ago. I think the breakage may have predated my time at CRL but definitely occurred in non-Bazel CI in addition to Bazel CI, where the test itself doesn't make much sense either way.

We're in need of a new linter for this: #81526

@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants