Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Fix mutex leak within TestCheckConstraintDropAndColumn #107915

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

rimadeodhar
Copy link
Collaborator

The test does not unlock the jobControlMu mutex in the case of an error. This PR fixes that.

Epic: none
Fixes: #107433
Release note: none

@rimadeodhar rimadeodhar marked this pull request as ready for review July 31, 2023 21:16
@rimadeodhar rimadeodhar requested a review from a team as a code owner July 31, 2023 21:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rimadeodhar rimadeodhar added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-22.2.x labels Jul 31, 2023
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/sql/schema_changer_test.go Show resolved Hide resolved
The test does not unlock the jobControlMu mutex in the case
of an error. This PR fixes that.

Epic: none
Fixes: cockroachdb#107433
Release note: none
@rimadeodhar
Copy link
Collaborator Author

TFTR

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 1, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 2, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential mutex leaks
3 participants